Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change "#ifdef WIN32" to "#ifdef _WIN32" #19254

Merged
merged 3 commits into from
Jan 24, 2024
Merged

Change "#ifdef WIN32" to "#ifdef _WIN32" #19254

merged 3 commits into from
Jan 24, 2024

Conversation

snnn
Copy link
Member

@snnn snnn commented Jan 24, 2024

Description

_WIN32 is a standard macro listed at https://learn.microsoft.com/en-us/cpp/preprocessor/predefined-macros?view=msvc-170 . But WIN32 is not.

Motivation and Context

@snnn snnn mentioned this pull request Jan 24, 2024
Merged
@snnn snnn requested review from pranavsharma, a team and yuslepukhin January 24, 2024 04:28
@Craigacp
Copy link
Contributor

It's wrong here as well - https://github.com/microsoft/onnxruntime/blob/main/java/src/main/native/ai_onnxruntime_OrtSession_SessionOptions.c#L321

yuslepukhin
yuslepukhin approved these changes Jan 24, 2024
View reviewed changes
Copy link
Member

@yuslepukhin yuslepukhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

yuslepukhin
yuslepukhin requested changes Jan 24, 2024
View reviewed changes
Copy link
Member

@yuslepukhin yuslepukhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕐

@yuslepukhin
Copy link
Member

#ifdef WIN32

Please, scan the code base for other occurrences.

Refers to: java/src/main/native/ai_onnxruntime_OrtSession_SessionOptions.c:321 in edcbcb5. [](commit_id = edcbcb5, deletion_comment = True)

@snnn snnn requested a review from a team as a code owner January 24, 2024 19:53
yuslepukhin
yuslepukhin approved these changes Jan 24, 2024
View reviewed changes
Copy link
Member

@yuslepukhin yuslepukhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@snnn snnn merged commit a28abeb into main Jan 24, 2024
98 checks passed
@snnn snnn deleted the snnn-patch-12 branch January 24, 2024 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yufenglee yufenglee yufenglee approved these changes

@yuslepukhin yuslepukhin yuslepukhin approved these changes

@pranavsharma pranavsharma Awaiting requested review from pranavsharma

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@snnn @Craigacp @yuslepukhin @yufenglee